Use std::variant in treelite::Model; clean up serializer

dmlc / treelite

Universal model exchange and serialization format for decision tree forests

https://treelite.readthedocs.io/en/latest/

Apache License 2.0

730 stars 98 forks source link

Closed hcho3 closed 1 year ago

hcho3 commented 1 year ago

Use std::variant to implement type dispatching in treelite::Model. Previously, type dispatching was implemented with inheritance, leading to non-idiomatic boilerplates. Closes https://github.com/dmlc/treelite/issues/472
Clean up the serialization logic using mix-in classes. Closes https://github.com/dmlc/treelite/issues/478. Now all the serialization logic lives in detail/serializer.h.

hcho3 commented 1 year ago

Closing in favor of #508