dmlc / treelite

Universal model exchange and serialization format for decision tree forests
https://treelite.readthedocs.io/en/latest/
Apache License 2.0
730 stars 98 forks source link

Add legacy model builder #527

Closed hcho3 closed 11 months ago

hcho3 commented 11 months ago

Also make the new model builder API a bit more ergonomic.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (82b48c6) 83.44% compared to head (852f48a) 70.43%.

:exclamation: Current head 852f48a differs from pull request most recent head da4d461. Consider uploading reports for the commit da4d461 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v4 #527 +/- ## =========================================== - Coverage 83.44% 70.43% -13.01% =========================================== Files 67 67 Lines 5551 5145 -406 Branches 426 0 -426 =========================================== - Hits 4632 3624 -1008 - Misses 919 1521 +602 ``` | [Files](https://app.codecov.io/gh/dmlc/treelite/pull/527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dmlc) | Coverage Δ | | |---|---|---| | [python/treelite/\_\_init\_\_.py](https://app.codecov.io/gh/dmlc/treelite/pull/527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dmlc#diff-cHl0aG9uL3RyZWVsaXRlL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [python/treelite/model\_builder.py](https://app.codecov.io/gh/dmlc/treelite/pull/527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dmlc#diff-cHl0aG9uL3RyZWVsaXRlL21vZGVsX2J1aWxkZXIucHk=) | `92.50% <100.00%> (+1.03%)` | :arrow_up: | | [python/treelite/model\_builder\_legacy.py](https://app.codecov.io/gh/dmlc/treelite/pull/527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dmlc#diff-cHl0aG9uL3RyZWVsaXRlL21vZGVsX2J1aWxkZXJfbGVnYWN5LnB5) | `80.66% <80.66%> (ø)` | | ... and [51 files with indirect coverage changes](https://app.codecov.io/gh/dmlc/treelite/pull/527/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dmlc)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.