search

dmlc / treelite

Universal model exchange and serialization format for decision tree forests
https://treelite.readthedocs.io/en/latest/
Apache License 2.0
730 stars 98 forks source link

Don't fetch GTest if it's found by CMake #539

Closed trxcllnt closed 8 months ago

trxcllnt commented 8 months ago

The CMake variable is GTest_FOUND not GTEST_FOUND.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (70a3c6d) 84.44% compared to head (484254e) 84.21%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## mainline #539 +/- ## ============================================ - Coverage 84.44% 84.21% -0.24% ============================================ Files 70 70 Lines 6063 6063 Branches 510 510 ============================================ - Hits 5120 5106 -14 - Misses 943 957 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hcho3 commented 8 months ago

Thanks! I will make sure to backport this patch to the upcoming 4.0 release.