search

dmlc / treelite

Universal model exchange and serialization format for decision tree forests
https://treelite.readthedocs.io/en/latest/
Apache License 2.0
730 stars 98 forks source link

[Breaking] Set 1st dim of prediction output to be row ID #549

Closed hcho3 closed 7 months ago

hcho3 commented 7 months ago

When performing tree prediction in parallel, it is common to split the workload over the data row dimension. So it would be beneficial to put the row ID as the first (outer-most) dimension. In addition, both XGBoost and scikit-learn RandomForestRegressor puts the row ID in the first dimension when predicting with multi-target models.

codecov[bot] commented 7 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5b1bbff) 84.33% compared to head (c509bfa) 84.29%.

Files Patch % Lines
src/gtil/predict.cc 95.83% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## mainline #549 +/- ## ============================================ - Coverage 84.33% 84.29% -0.04% ============================================ Files 71 71 Lines 6069 6068 -1 Branches 510 510 ============================================ - Hits 5118 5115 -3 - Misses 951 953 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.