Open andrew-esteban-imc opened 3 months ago
Thank you for reminding me of the fixme. Removing the column matrix requires changing other places as well since they expect a column matrix to be present. I will work on it after sorting out other priorities.
I've spotted that there's been a
FIXME
incolumn_matrix.h
since 2022 that constructs a column matrix for a DMatrix even when there's no missing value:In testing, this step seems to make up 30% of the time building a Quantile DMatrix, as well as contributes a decently large amount of memory consumption.
I'm very much not a CPP expert, so may be wrong in my understanding, but based on the presence of a FIXME (@trivialfis), I think a decently large performance boost can come from making this change.