Open hcho3 opened 1 month ago
Took a brief look into this for restoring the warning as error cmake option. It seems we need to build a part of the logger in xgboost to avoid symbols from dmlc.
@trivialfis Let's consider removing DMLC loggers and implementing the whole loggers inside XGBoost. And also: use prefixed macros like XGB_CHECK
and XGB_LOG
.
It's going to be a lot of work, we have to eliminate all dmlc headers that have logging in it. For example, we need to remove the dmlc parameter as well.
https://buildkite.com/xgboost/xgboost-ci-multi-gpu/builds/5220#018ff0f5-6610-44e5-adac-0b3e9bcf298f/99-444:
gRPC brings in Abseil C++, which defines its own
CHECK_*
macros. To avoid name collision, XGBoost's logging should use prefixed macros:XGB_CHECK
,XGB_CHECK_LT
etc.