dmlc / xgboost

Scalable, Portable and Distributed Gradient Boosting (GBDT, GBRT or GBM) Library, for Python, R, Java, Scala, C++ and more. Runs on single machine, Hadoop, Spark, Dask, Flink and DataFlow
https://xgboost.readthedocs.io/en/stable/
Apache License 2.0
25.8k stars 8.69k forks source link

New warning on CRAN. #10545

Open trivialfis opened 6 days ago

trivialfis commented 6 days ago

https://www.r-project.org/nosvn/R.check/r-devel-linux-x86_64-fedora-gcc/xgboost-00check.html

The warning must be addressed before Aug 03.

jameslamb commented 6 days ago

I was just looking at this, there is that one:

Result: WARN 
  Found the following significant warnings:
    ./include/xgboost/parameter.h:56:24: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
  See ‘/data/gannet/ripley/R/packages/tests-devel/xgboost.Rcheck/00install.out’ for details.
  * used C compiler: ‘gcc-14 (GCC) 14.1.0’
  * used C++ compiler: ‘g++-14 (GCC) 14.1.0’

But also these using icc:

* checking whether package ‘xgboost’ can be installed ... [12m/16m] WARNING
Found the following significant warnings:
  /usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/stl_tempbuf.h:263:8: warning: 'get_temporary_buffer<unsigned long>' is deprecated [-Wdeprecated-declarations]
  /usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/stl_tempbuf.h:263:8: warning: 'get_temporary_buffer<std::pair<float, unsigned int>>' is deprecated [-Wdeprecated-declarations]
  /usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/stl_tempbuf.h:263:8: warning: 'get_temporary_buffer<float>' is deprecated [-Wdeprecated-declarations]
  /usr/lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/stl_tempbuf.h:263:8: warning: 'get_temporary_buffer<xgboost::obj::ListEntry>' is deprecated [-Wdeprecated-declarations]

references:

jameslamb commented 6 days ago

For {lightgbm}, we received a similar warning from CRAN about template IDs in constructors.

I had success tonight replicating those in CI using the new container images from rhub: