search

dmmulroy / create-melange-app

The fastest, friendliest, and most delightful way to get started with OCaml, ReasonML, and Melange, geared towards JavaScript and TypeScript developers
104 stars 19 forks source link

Allow hyphens in application name #102

Open daniellionel01 opened 3 months ago

daniellionel01 commented 3 months ago

Hyphens are not allowed in the first step of naming your project. However if I'm creating a new directory from scratch with create-melange-app it is common practice put hyphens in your github repo name (as does this project lol) but then replace them with underscores for the ocaml application/package name.

So I think create-melange-app should allow hyphens and then just replace them with underscores when naming the OCaml project.

dmmulroy commented 2 months ago

i'm not sure that's a great idea, I think that just complicates things - it's a second name we have to track through the entire flow and make sure is threaded correctly to both the dune-project file and also the npm scripts.

dmmulroy commented 2 months ago

I'm open to pushback though, I think it's probably just easiest/best for people to rename the root folder when the wizard/tool is done running