Debatable / incorrect test case CL3 / 0088-no-decision-logic

dmn-tck / tck

Decision Model and Notation Technology Compatibility Kit

https://dmn-tck.github.io/tck

51 stars 36 forks source link

Debatable / incorrect test case CL3 / 0088-no-decision-logic #387

Open opatrascoiu opened 3 years ago

opatrascoiu commented 3 years ago

I believe the above test case is not CL3 compliant. Here is the rationale:

According to 2.1 (page 17) "An implementation claiming conformance to Conformance Level 3 SHALL comply with all of the specifications set forth in clauses 6 (Decision Requirements), 7 (Decision Logic), 8 (Decision Table) and 10 (Expression language) of this document."
According to 7.1 (page 71) "The decision logic level of a decision model in DMN consists of one or more value expressions." This is a semantic constraint on the DMN metamodel which provides only syntactic constraints.

We should move it into the non-compliant section of the test cases.

StrayAlien commented 3 years ago

Hi @opatrascoiu, section 7.1 also has the following (which we have agreed somewhere else is incorrect - if I recall):

If a decision element requires more than one business knowledge element, its value expression must be a literal expression that specifies how the business knowledge model elements are invoked and how their results are combined into the decision's outcome.
If a decision does not require any business knowledge models, its value expression must be a literal expression or decision table that specifies the entire decision logic for deriving the output from the inputs.

If all tests that did not satisfy these two were moved into non-compliant that would sure be a lot of them! I'm not saying the test you mention should not be moved, more saying that section 7.1 is fairly misleading. Which is a pretty bad thing in such a spec ....

StrayAlien commented 3 years ago

Btw @opatrascoiu - I raised https://issues.omg.org/issues/DMN14-139 to see if those silly sections of spec can be removed. But, I'll like to discuss this issue at monthly meeting if we can.

baldimir commented 1 year ago

Approved in DMN 1.5.

baldimir commented 1 year ago

Let's find out if the test is valid, and in which conformance level it should be, and we can resolve this on the next meeting.

opatrascoiu commented 1 year ago

The issue raised https://issues.omg.org/issues/DMN14-139 was addressed in DMN 1.5. The changes did not alter the text mentioned in the first comment. Hence, I believe the statements in the description of the issue are still valid:

According to 2.1 (page 17) "An implementation claiming conformance to Conformance Level 3 SHALL comply with all of the specifications set forth in clauses 6 (Decision Requirements), 7 (Decision Logic), 8 (Decision Table) and 10 (Expression language) of this document."

According to 7.1 (page 71) "The decision logic level of a decision model in DMN consists of one or more value expressions."

I believe that this is a semantic constraint.

Let's discuss!