dmn-tck / tck

Decision Model and Notation Technology Compatibility Kit
https://dmn-tck.github.io/tck
51 stars 36 forks source link

Issue in the 0068-feel-equality test? #682

Closed jvinis closed 5 days ago

jvinis commented 1 week ago

The description declares "...expects result: 'true (boolean)'", but the allowed answer is false! false (boolean)

Tests FEEL expression: 'date and time("2018-10-08T00:00:00+01:00") = date and time("2018-10-08T00:00:00@Europe/Paris")' and expects result: 'true (boolean)' Result of FEEL expression 'date and time("2018-10-08T00:00:00+01:00") = date and time("2018-10-08T00:00:00@Europe/Paris")'? false (boolean) date and time("2018-10-08T00:00:00+01:00") = date and time("2018-10-08T00:00:00@Europe/Paris")
opatrascoiu commented 1 week ago

@jvinis Thank you for raising this. I believe you are referring to the test for datetime_008. The comments in the DMN and TCK files are out of synch with the expected value in the TCK file. We need a PR to change the comments. Would you be able to do that?

jvinis commented 1 week ago

The problem is at the comments (0068-feel-equality.dmn) and at the expected value (0068-feel-equality-test-01.xml). The test expect false instead of true.

`

same datetimes, one with offset and the other with zone are equal
    <resultNode name="datetime_008" type="decision">
        <expected>
            <value xsi:type="xsd:boolean">false</value>
        </expected>
    </resultNode>
</testCase>`
opatrascoiu commented 1 week ago

@jvinis Yes, you are right, the boolean value specified in the comments (both DMN and TCK file) do not match the expected value (true in comments and false in expected value tag).

However, the test is correct (actual and expected values are the same). The offset of Europe/Paris between the summer transition (end of March) and autumn transition (end of October) is +02:00 not +01:00.

I can think of two options:

change the comments or change the test to reflect the intention stated in the TCK file by using the +02:00 offset.

opatrascoiu commented 1 week ago

I created a PR here https://github.com/dmn-tck/tck/pull/683 to address the issue.

baldimir commented 5 days ago

PR merged. Thanks for the issue and for the fix.