search

dmnfarrell / pandastable

Table analysis in Tkinter using pandas DataFrames.
Other
631 stars 126 forks source link

Inconsistency between getSelectedRow() and getSelectedRows() #206

Closed GBR-613 closed 2 years ago

GBR-613 commented 2 years ago

I would expect similarly named methods to have similar behavior. However the former returns the row number and the latter returns the rows content. I believe getSelectedRow() should return the selected row content and the selected row index should be returned by another function, getSelectedRowNumber() or getSelectedRowIndex() Alternatively, rename getSelectedRows() into getSelectedRowsContent()

dmnfarrell commented 2 years ago

Fair enough. I renamed getSelectedRows to getSelectedRowData as it's not really used anyway.