dmolsen / Detector

Detector is a simple, PHP- and JavaScript-based browser- and feature-detection library that can adapt to new devices & browsers on its own without the need to pull from a central database of browser information.
http://detector.dmolsen.com/
MIT License
847 stars 80 forks source link

Critical: WSOD in IE10 and IE11 #32

Closed carpusmedia closed 10 years ago

carpusmedia commented 10 years ago

Hello,

detector.dmolsen.com and our site using Detector results in a WSOD in IE10 and IE11, thus making this software unusable.

Anyone found a fix for this?

Thank you, Chris

afryer commented 10 years ago

Needs latest modernizer v3 which is not released via site but is available on github

https://github.com/Modernizr/Modernizr

Was gonna do a pull request but unsure on status of project

On 18 August 2014 12:07, carpusmedia notifications@github.com wrote:

Hello,

detector.dmolsen.com results in a WSOD in IE10 and IE11, thus making this software un-usable for any project.

Thank you, Chris

— Reply to this email directly or view it on GitHub https://github.com/dmolsen/Detector/issues/32.

carpusmedia commented 10 years ago

Ok, thanks for the heads up afryer. Gonna try it and report back.

Thank you, Chris

carpusmedia commented 10 years ago

Upgrading the Modernizr library to the latest version (2.8.3) solved the problem in both IE10 and IE11.

  1. Download the latest Modernizr version. Open up lib/modernizr/modernizr.2.5.2.min.custom.js and lib/modernizr/modernizr.2.5.2.min.no-tests.jsand use the links at the top of the documents to grab the latest Modernizr package for each build.
  2. Configure Detector to use the new Modernizr scripts. Open up lib/config.ini and change the uaFeaturesMaxJS and uaFeaturesMinJS to point to the new Modernizr scripts.

Thank you, Chris