search

dmonad / lib0

Monorepo of isomorphic utility functions
MIT License
347 stars 62 forks source link

Cleanup and Observable once fix #15

Closed daniel-jonathan closed 3 years ago

daniel-jonathan commented 3 years ago

Hi,

You have an issue with your Observable once API. It doesn't work. I made a fix for it, which now works. As well, no need to include your .vscode directory, and a couple other files that don't need to be committed.

dmonad commented 3 years ago

Hi @danieldahan ,

I appreciate that you took the initiative to fix the issue! Yeah, this is a bug, thanks for fixing it.

But in my projects I do commit package-lock.json (as is recommended) and I do commit .vscode files (just because I like it).

Would you like to publish another PR? Otherwise, I'm going to fix it in the next release.

dmonad commented 3 years ago

Looking at your github profile I guess you don't need the fame / experience of committing to this project ^^ I'm simply gonna publish a new release with the fix. Will be ready in a bit.

dmonad commented 3 years ago

Fixed in 0.2.34

daniel-jonathan commented 3 years ago

Thank you!! I was going to suggest to just fix it. I love your YJS project. My team and I have done something special with it that I think you would appreciate. I'll share when ready. All the best!

dmonad commented 3 years ago

@danieldahan Looking at CosmicMind I can't wait :)

Hook me up ASAP and if you want you could "show-off" your project in https://discuss.yjs.dev/.

daniel-jonathan commented 3 years ago

@dmonad Thank you! I plan to sponsor you once it is up and running :) And I'd love to share what we have done. Thanks again!