search

dmonad / lib0

Monorepo of isomorphic utility functions
MIT License
362 stars 65 forks source link

Add size limit #32

Closed flaviouk closed 2 years ago

flaviouk commented 3 years ago

Adds size limit checks into the pipeline.

Unfortunately because of lack of support of the tool, the config had to be written in .cjs and it's not able to parse pure esm yet (https://github.com/ai/size-limit/issues/227)

Still I think this adds value, but let me know what you think

dmonad commented 2 years ago

This tool is super cool! Thank you for pointing this out. It really makes sense to measure the size of "bundles" - like web apps. However, for lib0, I'm not so sure. lib0 exports pure module exports. A module bundler should be able to strip away everything that is not needed.

I'm super critical about everything that goes into lib0, as it should be as minimalistic as possible.

Feel free to discuss further, however, at this time, I'm not super convinced that I want to maintain this in lib0.