Iframe issue in Brave browser with environment.js - Githubissues

dmonad / lib0

Monorepo of isomorphic utility functions

MIT License

347 stars 62 forks source link

Iframe issue in Brave browser with environment.js #4

Closed LucasGenoud closed 4 years ago

LucasGenoud commented 4 years ago

We don't directly use lib0 but we use YJS and we allow to integrate a page from our app in an iframe, the page in the iframe doesn't load because of this error:

It seems this issue only happens in brave browser

dmonad commented 4 years ago

Interesting.. thanks for reporting. I will fix it.

dmonad commented 4 years ago

I fixed this issue in 0.2.17. I wasn't able to reproduce this problem, so let me know if you still have problems.

dmonad commented 4 years ago

FYI npm update should bump lib0 in your project.

LucasGenoud commented 4 years ago

Thank you very much, Altough in the YJS's package.json it's specified that the latest minor version should be installed, NPM keeped installing the 0.2.16 instead of 0.2.17 so i've made a pull request to force the latest version in yjs

dmonad commented 4 years ago

Does npm update not work for you?

LucasGenoud commented 4 years ago

It initially didn't update correctly but I've executed it again and it worked now... Also the initial issue seems to be fixed so thank you very much !

dmonad commented 4 years ago

Awesome! NP