search

dmonad / lib0

Monorepo of isomorphic utility functions
MIT License
345 stars 63 forks source link

Simpler handling surrogate pairs #46

Closed KentoMoriwaki closed 1 year ago

KentoMoriwaki commented 1 year ago

Simpler and more performant impl of https://github.com/dmonad/lib0/pull/45

Trade-off: This method does not guarantee behavior when the argument has an incorrect surrogate pair

Young6118 commented 1 year ago

Good job!

KentoMoriwaki commented 1 year ago

@dmonad I fixed and updated specs to improve coverages.

tommoor commented 1 year ago

The link in the original PR suggests that this would fix https://github.com/yjs/yjs/issues/303 however the behavior doesn't seem to have changed in regards to those original reproduction instructions. From what I can tell the same corruption is present.

KentoMoriwaki commented 1 year ago

@tommoor Are you certain you're using lib0@0.2.69 in your environment? I have verified that this issue has been resolved in mine.