search

dmonad / lib0

Monorepo of isomorphic utility functions
MIT License
345 stars 63 forks source link

Missing close method on LocalStoragePolyfill #61

Closed ryanb closed 1 year ago

ryanb commented 1 year ago

I'm seeing channel.bc.close is not a function when attempting to disconnect a broadcast channel. This is showing up on my CI server when attempting to upgrade lib0 beyond 0.2.58. I believe this was introduced in this commit which added a call to channel.bc.close.

I assume my CI server is using LocalStoragePolyfill which doesn't respond to close. Should that method be added?

I can provide further details on this if needed.

dmonad commented 1 year ago

Right, thanks! I fixed the issue in 0.2.70.

ryanb commented 1 year ago

Wow, you're fast. Thanks!