search

dmonad / lib0

Monorepo of isomorphic utility functions
MIT License
368 stars 65 forks source link

Circular Dependency (encoding.js, decoding.js and buffer.js) #77

Closed szilu closed 1 year ago

szilu commented 1 year ago

I couldn't reopen the other issue, so I created a new one.

I stumbled upon this issue, because I had encountered some strange issues using rollup in watch mode. I temporarily fixed the issue and it seems to be the cause. My fix was rather simple, I simply inlined all the occurences of "createUint8ArrayViewFromArrayBuffer()" to "new Uint8Array()" and dropped the buffer.js import from encoding.js and decoding.js.

Could you please fix this somehow? It's possible that this is a rollup issue, but it seems to be easily solvable.

Originally posted by @szilu in https://github.com/dmonad/lib0/issues/19#issuecomment-1752158507

dmonad commented 1 year ago

Please don't open the tenth duplicative issue just because I didn't respond within 20 minutes to the other ticket..

Also, I have responded in enough detail. Please read my past comments.