search

dmorse / pscfpp

Polymer Self-Consistent Field Theory (C++/CUDA version)
https://pscf-home.cems.umn.edu
GNU General Public License v3.0
25 stars 20 forks source link

Avoid creation of local FFT<D> objects in blocks #144

Closed dmorse closed 9 months ago

dmorse commented 9 months ago

Currently, in pspc/ and pspg/, each Block object has it's own FFT object. This should be changed so that all blocks can share a common FFT object that is owned by the main System. To do so, we must pass a reference to the FFT as well as the Mesh to the Mixture, and have it pass references to all blocks.

dmorse commented 9 months ago

Note: All unit tests involving Block and Mixture objects will need to modified as well as the System, Mixture, and Block classes.

dmorse commented 9 months ago

Completed in pscf_pc CPU code (Oct 26, 2023). Remains to done in pscf_pg.

dmorse commented 9 months ago

Resolved in commit be2984d (Oct. 27, 2023)