search

dmorse / pscfpp

Polymer Self-Consistent Field Theory (C++/CUDA version)
https://pscf-home.cems.umn.edu
GNU General Public License v3.0
25 stars 20 forks source link

Adding intra and LrPostAmCompressor #177

Closed chen7545 closed 2 months ago

dmorse commented 2 months ago

Kexin, As we discussed, please make intraCorrelation a member of each compressor subclass that needs to use it, rather than a dynamically allocated object that is assigned to an intraCorrelationPtr pointer variable. I don't see any reason to provide access outside of the class, so I would also remove the intraCorrelation() accessor function and just access the member directly for code inside the class.

dmorse commented 2 months ago

I decided to accept the pull request, and ask you to change it to a member in a separate pull request when you get a chance.