dmorse / pscfpp

Polymer Self-Consistent Field Theory (C++/CUDA version)
https://pscf-home.cems.umn.edu
GNU General Public License v3.0
30 stars 20 forks source link

Add ParameterModifier feature into r1d and rpg #180

Closed benmagruder closed 3 months ago

benmagruder commented 3 months ago

This pull request contains the modifications necessary for the ParameterModifier feature to work in r1d and rpg. Currently, there are no specialized sweep parameters in either of these namespaces, so the code in this pull request does not have an example that can easily be run to test that it all works smoothly like we are able to do in rpc. However, a unit test in rpg::SweepTest was added that checks that specialized parameters can be read properly from a file, and this unit test passed. Further, the code in r1d and rpg that was added in this pull request is almost identical to the code that was added in rpc in a previous pull request, so it is expected to work properly if/when we eventually introduce specialized parameters in these namespaces.

All unit tests have been run on this code (including GPU unit tests) and they all pass.