dmort27 / epitran

A tool for transcribing orthographic text as IPA (International Phonetic Alphabet)
MIT License
625 stars 120 forks source link

Epitran overwrites global logging object with highest level #154

Open matgrioni opened 1 year ago

matgrioni commented 1 year ago

In flite.py, which is included in epitran.py and therefore in __init_\.py for the whole package the following line is found:

logging.basicConfig(level=logging.CRITICAL)

This sets the logging for the entire program / module and leads to very surprising behavior and difficulty in debugging. Is there a reason for this call? Ideally it can be removed or replaced with some equivalent that does not impact the overall program level. Really I don't think a library should be setting this type of configuration since the library users will have the context on how the logging should be configured.