search

dmotz / oriDomi

🪭 Fold up DOM elements like paper
https://oxism.com/oriDomi
MIT License
2.41k stars 207 forks source link

Semantic document outline and accessibility #34

Closed jaydenseric closed 10 years ago

jaydenseric commented 10 years ago

oriDomi creates many copies of HMTL elements to create the fold effect. This can really bloat the semantic document outline with copies of headings in particular, potentially causing headaches for accessibility (see screenshot).

Could this be mitigated by applying an attribute such as aria-hidden="true" to all the duplicate layers?

oriDomi document outline screenshot

dmotz commented 10 years ago

Great point. I'll add the aria attributes soon.

dmotz commented 10 years ago

Just pushed an update that adds an aria attribute on the cloned elements. I tested it with a screen reader and they're ignored. You'll still see them in the document outline though, but it's a big improvement over how screen readers were handled before.

getsetbro commented 9 years ago

screenshot_2015-08-22-08-56-14 Is there a fix for the repetition in search results!

dmotz commented 9 years ago

@getsetbro This happens if the crawler runs client side scripts and indexes the modified DOM. I don't know of any way to conditionally exclude content from a crawler. If you do, let me know.