search

dmoulding / boilermake

A reusable, but flexible, boilerplate Makefile.
GNU General Public License v3.0
192 stars 28 forks source link

missing dependencies on submakefiles #10

Open mzemb opened 8 years ago

mzemb commented 8 years ago

Hi there.

First, thanks for sharing your work. And good job as for code clarity: it's very readable in spite of make syntax not being that easy.

That said, I think that there is a design flaw: the targets do not depend on the submakefiles. In your test-app, if I run make (to build all), and then I change something in one of the .mk files (say a -O0 in -O2), the next call to make outputs "nothing to be done" instead of rebuilding everything impacted by the option change.

I tried fixing it by introducing the name of the submakefile as fourth parameter to ADD_TARGET_RULE macro in order to add it to the dependencies, but I didn't succeed.

Can you fix that or suggest another way to come to the expected behaviour ?

Regards,

Michael

igagis commented 8 years ago

The author seems silent. May I suggest https://github.com/igagis/prorab

mzemb commented 8 years ago

It looks interesting. I'll take a deeper look the next time I invest time into the build system.