dmpayton / django-admin-honeypot

:honey_pot: A fake Django admin login screen page.
http://django-admin-honeypot.readthedocs.io/
MIT License
1.03k stars 188 forks source link

Fixed deprecation warnings, flake8 of code and added python and django's to travis #74

Open GitRon opened 4 years ago

GitRon commented 4 years ago
GitRon commented 4 years ago

Hi @dmpayton

I fixed the deprecations and did some more stuff but the tests seems to fail now even though I didn't change anything at these points. Do you know if it was maybe broken before?

Thanks! Ronny

GitRon commented 4 years ago

Btw, I extended the travis matrix so we get proper check for all the relevant pyhton and django combinations.

9mido commented 4 years ago

Awesome work @GitRon ! Would you also be able to make a PR for issue 62? That way, the newest version for django 3 compatibility will get pushed to PyPi along with your PR.

GitRon commented 4 years ago

@9mido quite busy at the moment but I'll see what I can do

GitRon commented 4 years ago

@9mido I put this idea into a PR. Happy? :)

9mido commented 4 years ago

@GitRon Yes you rock! Woohoo!

Just wondering though the checks for it look like they have failed. Any ideas how to fix those?

I feel really dumb the PR you made looks very simple lol.

GitRon commented 4 years ago

@dmpayton @9mido Pipeline is fixed and PR is ready to merge.

GitRon commented 3 years ago

@dmpayton @9mido Would be awesome if somebody could review and merge it 😃

blag commented 3 years ago

Hi, I have forked this project, included a few PRs (including this one), and released a package to PyPI. You might have better luck with my fork.