dmpe / urlshorteneR

R package for 2 URL shortening service :loudspeaker: Compatible with Bitly API v4
http://cran.r-project.org/package=urlshorteneR
Apache License 2.0
22 stars 7 forks source link

Migrate bit.ly from v3 to v4. Test with others too #13

Closed RickPack closed 5 years ago

RickPack commented 5 years ago

I am seeing Code: 500 - MISSING_ARG_ACCESS_TOKEN when I call functions including bitly_UserInfo(). Might this mean I am not properly authorized?

bitly_token is not returning an error and shows:

authorize: https://bitly.com/oauth/authorize access: https://api-ssl.bitly.com/oauth/access_token bitly key: 0f5320d633ef283e8dbc7165c96071033b79e3f3 secret: status_code, data, status_txt --- A cause of the problem could be my entries in the bit.ly OAUTH APP registration, namely: APPLICATION LINK: http://localhost:1410/ REDIRECT URIS: http://localhost:1410/ `bitly_token$credentials$status_code` returns 401, which apparently means UNAUTHORIZED. Forgive me, I am not very familiar with the web authentication space. A review of https://dev.bitly.com/authentication.html did not help.
dmpe commented 5 years ago

this weekend will reply :) EDIT: Ok, now I understand. @RickPack Thank you again for correcting the typo(s).

I will close now. Please reopen this ticket if you think that the issue still persists.

RickPack commented 5 years ago

@dmpe , Can you reopen this issue? The typo I fixed was for an unrelated example. I am still seeing the Code: 500 error. Are you? Thank you.

dmpe commented 5 years ago

Most probably because they have released a new API version v4 which I do not remember working with. https://dev.bitly.com/v4_documentation.html

This will take a (quite some) time to investigate/fix/migrate. I make no promises.

RickPack commented 5 years ago

Can you assign this issue to me for now? I am going to give it a try if time allows this week. I'll let you know if I cannot complete the task. I'm thinking the "HTTP Basic Authentication Flow" section of the bitly API 4.0.0 instructions https://dev.bitly.com/v4_documentation.html could help.

On Mon, Feb 11, 2019 at 3:05 AM John notifications@github.com wrote:

Most probably because they have released a new API version v4 which I do not remember working with. https://dev.bitly.com/v4_documentation.html

This will take a (quite some) time to investigate/fix/migrate. I make no promises.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dmpe/urlshorteneR/issues/13#issuecomment-462244312, or mute the thread https://github.com/notifications/unsubscribe-auth/ACoy891Tfbiv1BSTelrZK1M9zjb8Qc7-ks5vMSRMgaJpZM4avDnA .

RickPack commented 5 years ago

Thanks, @dmpe. Pulled in too many directions right now.

dmpe commented 5 years ago

Ok, sure just, merge my recent cosmetic changes git rebase etc

dmpe commented 5 years ago

@senthilthyagarajan, I am working on this. Will increase the priority of this

dmpe commented 5 years ago

Note to myself: https://support.bitly.com/hc/en-us/articles/230647407-How-do-I-increase-my-Bitly-API-limits-

dmpe commented 5 years ago

@RickPack I done here. migration to v4 has been accoplished. Please test and open new issues ....thanks.