dmpe / urlshorteneR

R package for 2 URL shortening service :loudspeaker: Compatible with Bitly API v4
http://cran.r-project.org/package=urlshorteneR
Apache License 2.0
22 stars 7 forks source link

Failure with dev version of testthat #7

Closed hadley closed 9 years ago

hadley commented 9 years ago
checking tests ... ERROR
Running the tests in ‘tests/testthat.R’ failed.
Last 13 lines of output:

      View

  1. Failure (at test-UserMetrics.R#18): Returns the aggregate number of clicks on all of the authenticated user's Bitlinks. 
  umc not equal to 6
  7 - 6 == 1

  testthat results ================================================================
  OK: 29 SKIPPED: 0 FAILED: 1
  1. Failure (at test-UserMetrics.R#18): Returns the aggregate number of clicks on all of the authenticated user's Bitlinks. 

  Error: testthat unit tests failed
  Execution halted
DONE
Status: 1 ERROR

I'm going to submit to CRAN later today, so you may want to prepare a new release soon. Not sure why this didn't come up in the previous checks, although given the test text, it may be a problem on your end.

dmpe commented 9 years ago

Thanks Hadley, I fixed it. Or at least I believe I fixed that. In any case, you can push testthat and ignoring any warnings from my package.