dmphillippo / multinma

Network meta-analysis of individual and aggregate data in Stan
https://dmphillippo.github.io/multinma
35 stars 16 forks source link

Update deprecated syntax for future rstan compatibility #25

Closed andrjohns closed 1 year ago

andrjohns commented 1 year ago

Now that rstan 2.26 is available on CRAN we need to update the deprecated syntax in your package's Stan models, otherwise it will fail to install with an upcoming version of RStan.

The following updates have been made:

More information about the deprecated and removed syntax in Stan can be found here:

If you could merge and submit to CRAN soon, it would be greatly appreciated.

Let me know if you have any questions about these changes.

Thanks!

dmphillippo commented 1 year ago

Thanks @andrjohns, merging now!

(The test failures are only stochastic. Updates seem to change the seeding process very slightly each time, which breaks an occasional test. I'll fix these 🙂)

andrjohns commented 9 months ago

@dmphillippo would it be possible to push these changes to CRAN soon? Otherwise your package will break with the next rstan version

dmphillippo commented 9 months ago

Hi @andrjohns, yes absolutely, sorry for the delay. This package update includes some substantial new features, so I'm trying to sync up the CRAN release with a paper submission/arXiv preprint - which I'm finalising as we speak.

Do you have a timeline for the next rstan release?

dmphillippo commented 9 months ago

@andrjohns This is on CRAN now with version 0.6.0.

Thanks 🙂