search

dmpop / pellicola

Pastebin for your photos
https://tinyvps.xyz/pellicola
GNU General Public License v3.0
165 stars 16 forks source link

Fix for sort order, missing picture and text files showing up in the … #26

Closed rpoulin closed 4 years ago

rpoulin commented 4 years ago

…grid

Fixed issues 24 and 25. Tested the script using 37 pictures to make sure the sort order is what it is supposed to be, forward and reverse, fixed pagination issues caused by a reverse enumeration order implemented in earlier commit.

This script is in bad shape: 1) It needs to be refactored so that the structure of the script makes sense to the human programming mind. 2) Needs linting 3) Should use boolean values where booleans are needed instead of numerics and nulls 4) Should implement modern GUI tools like Bootstrap to ensure container breaks work across hardware platforms and conformity to modern css rules and guidelines

This app is really worth saving. The idea is a good one. I can think of a dozen features to add to it if you would like to spend time on it.

I have test photos to send you if you would like to have them. I decided to use a photo that I created this morning that really weeds out sort errors, missing frames etc. It is a big archive (186Mb). Let me know if you are interested, I will post it on my little server for you to pull if you want it.

dmpop commented 4 years ago

Thank you so much for your pull request! Mejiro was a learning experience for me, so the quality of code (or the lack of thereof) have a lot of room for improvement. If if you have ideas, comments, and improvements, don't hesitate to ping me!