Code improvements (refactoring)

dmpop / sonnenhut

Simple dashboard for photographers

GNU General Public License v3.0

5 stars 0 forks source link

Closed tomschr closed 7 years ago

tomschr commented 7 years ago

Surprise, surprise. Here is another PR. 😆 This PR includes the following changes:

Check values now in test_getdarksky_check_values() to make stricter testcase
Add missing return_value parameter
Introduce safeget() to avoid ugliness of try..except. This part was especially tricky.
Introduce process_rss() to simplify for loop in fetchrss()

Overall change should make code "cleaner" and easier to read. Hope you like it! 😁

tomschr commented 7 years ago

Ok, back again. Do you have any further questions?

dmpop commented 7 years ago

Welcome back! 😄 No, no questions. Will merge ASAP.

tomschr commented 7 years ago

Thanks! 👍