search

dmpstats / stochCRM

Graphical User Interface (GUI) developed for a stochastic avian Collision Risk Model (CRM)
7 stars 1 forks source link

Density upload column reordering #6

Closed MarkTrinder closed 5 years ago

MarkTrinder commented 5 years ago

I think the upload density option is rearranging months alphabetically - I just uploaded Distribution samples but couldn't understand the weird results until I re-ordered the upload data! Don't know if this will also apply to the Distribution reference points but I guess thats possible?!

MarkTrinder commented 5 years ago

more... I tried re-ordering the columns of my density data to get them in the 'right' sequence, which I seem to have achieved ok, but the results for each month were mixed up again. So I have run the model using the apparently wrong month order for densities and this seems to be giving the right answers! So the month re-ordering seems to just be the plots of input densities, but the actual model is treating them in the right order.

To illustrate, here are the input densities as plotted (wrongly): image

and here are the option2 outputs (in correct order): image

these should follow the same pattern!

bcaneco commented 5 years ago

Hi Mark, Yes, indeed, that's a bug in the code! Upon checking, the cheeky bug is sitting on the chuck of code producing the input density plots, on both the distribution samples and reference points. However, the input data is entered in the model correctly on both cases.

The bug has been squashed in the development code and the issue will be resolved upon the next version release, which will hopefully be out soon.

Thanks for spotting it!

MarkTrinder commented 5 years ago

Hi Bruno

Is this corrected in the version to download yet? I need to run the model for real with my own density samples for an assessment with a deadline fast approaching. Thanks Mark

From: bcaneco notifications@github.com Sent: 07 December 2018 14:40 To: dmpstats/stochCRM stochCRM@noreply.github.com Cc: Mark Trinder Mark.Trinder@macarthurgreen.com; Author author@noreply.github.com Subject: Re: [dmpstats/stochCRM] Density upload column reordering (#6)

Hi Mark, Yes, indeed, that's a bug in the code! Upon checking, the cheeky bug is sitting on the chuck of code producing the input density plots, on both the distribution samples and reference points. However, the input data is entered in the model correctly on both cases.

The bug has been squashed in the development code and the issue will be resolved upon the next version release, which will hopefully be out soon.

Thanks for spotting it!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/dmpstats/stochCRM/issues/6#issuecomment-445252332, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AZjIjVcqL22X_mwRlL2jh2DzNjA46Mf_ks5u2n3WgaJpZM4ZBXyO.

bcaneco commented 5 years ago

Hi Mark, I've just uploaded the repository with an updated version of the app (v2.2.2), where this issue should be resolved. It's really just a quick patch to fix the bug, as a fresher version with additional features (mainly focussed on user support, e.g. storing and restoring input values) will be released in a not too distant future.

Thanks for your help.

MarkTrinder commented 5 years ago

thanks

From: bcaneco notifications@github.com Sent: 25 January 2019 11:27 To: dmpstats/stochCRM stochCRM@noreply.github.com Cc: Mark Trinder Mark.Trinder@macarthurgreen.com; Author author@noreply.github.com Subject: Re: [dmpstats/stochCRM] Density upload column reordering (#6)

Hi Mark, I've just uploaded the repository with an updated version of the app (v2.2.2), where this issue should be resolved. It's really just a quick patch to fix the bug, as a fresher version with additional features (mainly focussed on user support, e.g. storing and restoring input values) will be released in a not too distant future.

Thanks for your help.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/dmpstats/stochCRM/issues/6#issuecomment-457543733, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AZjIjUpLZOY1Db8gDLGD_5W267HsDA4Jks5vGuohgaJpZM4ZBXyO.

bcaneco commented 5 years ago

Closing issue as bug fixed