search

dmptrluke / django-markdownfield

A simple custom field for Django that can safely render Markdown and store it in the database.
MIT License
43 stars 13 forks source link

Get rid of RemovedInDjango41Warning #11

Closed benjaoming closed 10 months ago

benjaoming commented 2 years ago

Since Django 3.2, default_app_config wasn't needed. The slight problem is that 2.2 and 3.1 still need it (and are still supported)

So removing default_app_config means that projects in 2.2 and 3.1 have to specify the exact AppConfig path in INSTALLED_APPS.

It's a pickle. Perhaps not so interesting to address, but this was the first time that I stumbled upon it. I think that it's been deprecated to eagerly since reusable apps that want to support all currently supported Django versions will then either have to cut support or live with the deprecation warnings. Or maybe I'm missing something.

.virtualenvs/dukop/lib/python3.8/site-packages/django/apps/registry.py:91: RemovedInDjango41Warning: 'markdownfield' defines default_app_config = 'markdownfield.apps.MarkdownFieldConfig'. Django now detects this configuration automatically. You can remove default_app_config.
    app_config = AppConfig.create(entry)
benjaoming commented 10 months ago

It doesn't look like Django 2.2 and 3.1 are supported anymore.

@dmptrluke are you okay with 5d26ba8 ?

dmptrluke commented 10 months ago

It doesn't look like Django 2.2 and 3.1 are supported anymore.

@dmptrluke are you okay with 5d26ba8 ?

Sounds good to me, since they're no longer supported

benjaoming commented 10 months ago

Great! I was gonna bump to 0.11 in another PR but forgot to commit a GitHub suggestion, so doing it here and squashing :+1: