search

dmptrluke / django-markdownfield

A simple custom field for Django that can safely render Markdown and store it in the database.
MIT License
44 stars 13 forks source link

Fix field margin and fullscreen z-index #33

Closed kavdev closed 1 year ago

kavdev commented 1 year ago

Probably needs to be tested in older versions of django to check compatability, but this fixes the ui in the latest django version.

The margin-left is no longer necessary, since the django admin frame seems to handle field responsiveness.

The z-index is necessary to get the fullscreen editor to appear above the sidebar.

benjaoming commented 1 year ago

Thanks for looking into this :+1:

Did you test this on Django 3.2?

dmptrluke commented 1 year ago

I still have a live deployment running Django 3.2 that I haven't quite updated yet. I'll give this a go tonight.

dmptrluke commented 1 year ago

image Tested on Django 3.2, there seems to be a bit of a display issue with the toolbar, but it does fix the overlap issue.

dmptrluke commented 1 year ago

What does the margin removal fix on newer versions of Django?

kavdev commented 1 year ago

What does the margin removal fix on newer versions of Django?

Here's the current behavior on 4.2:

After the fix:

dmptrluke commented 1 year ago

I'm going to leave the change as it is for now, because the layout issue on newer versions is more impactful, and newer versions are more likely to be used. I have logged #34 for the regressions on 3.2.