BUG: MT threads was not set, causing FOD discretization to use all CPUs

dmritrekker / trekker

dMRI based fiber tracking using parallel transport tractography

https://dmritrekker.github.io

BSD 3-Clause "New" or "Revised" License

17 stars 12 forks source link

BUG: MT threads was not set, causing FOD discretization to use all CPUs #14

Closed cookpa closed 1 year ago

cookpa commented 1 year ago

The tracking uses the number of threads set on the command line (GENERAL::numberOfThreads), but the FOD discretization uses MT::maxNumberOfThreads, which doesn't get changed from its default of all CPUs. On an HPC cluster, this causes a spike in resource uses, leading to jobs being terminated.

cookpa commented 1 year ago

Hi,

Thanks for making this nice software! This PR addresses a performance issue mostly affecting HPC users. Thanks @valeriejill and @mattcieslak for finding the problem

baranaydogan commented 1 year ago

I think it is better to be consistent with the use of CPU cores in the whole application. Thank you @cookpa, @valeriejill and @mattcieslak for the fix! I will update the binaries later too. This will go to v0.9 release.