dmroeder / pylogix

Read/Write data from Allen Bradley Compact/Control Logix PLC's
Apache License 2.0
598 stars 182 forks source link

Fix 'raw' option in iep.py for _GetPLCTime & example 21 #130

Closed David-2D3FE9 closed 4 years ago

David-2D3FE9 commented 4 years ago

Fix _getPLCTime in eip.py about 'raw' option Fix example 21_get_plc_clock.py witch gave a print error due to incorrect object called

Short description of change

Types of changes

What is the change?

Added misssing esle statement in eip.py => _getPLCTime -> raw option didn't work Modified print details in example 21_get_plc_clock.py -> Wrong returned objects

What does it fix/add?

Raw value for getting PLC time works now No more error when running example 21_get_plc_clock.py

Test Configuration

TheFern2 commented 4 years ago

Thanks for the PR, was almost a perfect PR, just a few tips. Whenever you see a pull request template or any other template in the docs folder in any github repository, those are automatically used when you open an issue or new PR. You'll edit it when you make the PR or open an issue, you don't edit the file itself, it will auto populate for you as markdown.

It is most convenient to do patches on branches rather than master.

Lastly is to rev up the version number on init.py but don't worry I'll work on a more formal document on how to create a PR for pylogix.

I made a small modification to the example so we can still show the user, all the bits of information possible with the returned value.