search

dmroeder / pylogix

Read/Write data from Allen Bradley Compact/Control Logix PLC's
Apache License 2.0
598 stars 182 forks source link

New Boolean tests #154

Closed TheFern2 closed 3 years ago

TheFern2 commented 3 years ago

Short description of change

I've added a new test fixture, which tests our current BaseBOOLArray[128]. Not sure what is going on yet, but feeding a list of boolean with more than 4 tags causes the rest to return Path destination unknown. I made the PR just in case we need to add more tests, I'll merge after #151 is complete if there are any bugs to be fixed.

Types of changes

What is the change?

This should help to test #151 Here you can change it to anything below 128 since that's the size of BaseBOOLArray

    def test_bool_list(self):
        tags = self.bool_list_fixture(128)
        self.multi_read_fixture(tags)

What does it fix/add?

A better unit test for testing boolean lists to ensure Status is successful.

TheFern2 commented 3 years ago

@dmroeder just did some extensive testing on this branch on several other version tags, and it is safe to merge.