Fix whitespace in pytlogix.lgx_device.vendors - Githubissues

dmroeder / pylogix

Read/Write data from Allen Bradley Compact/Control Logix PLC's

Apache License 2.0

598 stars 182 forks source link

Fix whitespace in pytlogix.lgx_device.vendors #214

Closed drbitboy closed 1 year ago

drbitboy commented 1 year ago

Leading space for vendorID 248
TAB for vendorID 721

Short description of change

Types of changes

Fix whitespace in pytlogix.lgx_device.vendors

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] I have read the docs/CONTRIBUTING.md document.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read tests/README.md.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

What is the change?

What does it fix/add?

Test Configuration

PLC Model
PLC Firmware
pylogix version
python version
OS type and version

TheFern2 commented 1 year ago

This PR is not necessary. When we're done with micropython/patch1 it will be merged with master which will include everything done in that branch including the removal of the space in strings. In addition to the dict being in an entire different py file for file loading efficiency for micropython.