search

dmroeder / pylogix

Read/Write data from Allen Bradley Compact/Control Logix PLC's
Apache License 2.0
598 stars 182 forks source link

Hacktoberfest help wanted, pep8 issues #81

Closed TheFern2 closed 5 years ago

TheFern2 commented 5 years ago

Hey github peeps,

I've noticed there are a few pep8 issues on the main file eip.py that would be perfect for first time submitters, and help you stack a PR for hacktoberfest rep.

https://github.com/PyCQA/pycodestyle https://www.python.org/dev/peps/pep-0008/

If you are new to git, an awesome guide is here https://github.com/firstcontributions/first-contributions

Pycodestyle is what used to be known as pep8, you run that module against a py file and it tells you syntax errors. That is your mission to help this repo be free of pep8 issues. Can you help us?

For example this is a branch I am working on, and I have been really naughty:

py -3.7 -m pycodestyle --first pylogixTests.py
pylogixTests.py:3:64: W291 trailing whitespace
pylogixTests.py:24:1: E402 module level import not at top of file
pylogixTests.py:25:17: E261 at least two spaces before inline comment
pylogixTests.py:225:80: E501 line too long (80 > 79 characters)
GilSandler commented 5 years ago

Hey, A first-time open source contributor here :) Will try to fix the issue.

TheFern2 commented 5 years ago

Thanks @GilSandler any questions feel free to ask.

TheFern2 commented 5 years ago

@GilSandler I think the only pep issue we can leave is the W291 trailing whitespace at the top of the file, but other than that is all game, if you want to fix 5 or so, and leave some for others to contribute but is up to you. You can fix all if you'd like.

GilSandler commented 5 years ago

@kodaman2 Actually already fixed almost all of the errors. I'm gonna take your suggestion and let others contribute as well :)