dmstocking / sick-stache

Android app for managing SickBeard.
GNU General Public License v3.0
22 stars 9 forks source link

SickRage Compatability #30

Open laurentbeost opened 9 years ago

laurentbeost commented 9 years ago

Hello,

It seems that this app' does not work properly on Android 5.0. I don't know if it is planned to add support for Lollipop, but here is the error i get : "Error Retrieving Results ERROR : Attempt to read from field 'boolean org.sickbeard.json.type.JsonBoolean.value' on a null object reference".

Would it be possible to fix it ? Thank you.

dmstocking commented 9 years ago

Are you sure you are running normal "SickBeard" and not some fork, like SickRage? I dont think the SickBeard api has changed at all since like 2013. I can try to connect with a 5.0 emulator to test this but that error seems really weird if it was a lolipop only problem.

laurentbeost commented 9 years ago

Thank you for your reply.

Since I received the Lollipop OTA a few days ago and the app' has stopped working just after that, I thought that was a Lollipop issue; but it seems that I was wrong.

Indeed, I'm running a fork : sickrage on the master branch. I didn't think that this fork could cause such problems, like json decoding errors. I think I'll try the original sickbeard version to check the compatibility.

dmstocking commented 9 years ago

There was this problem. https://sickrage.tv/forums/forum/help-support/bug-issue-reports/3373-api-with-sickstache/page2 IDK if it still is like this. He fixed by adding "api" to the Extra Path option.

laurentbeost commented 9 years ago

I tested with sickbeard on master version : it's working fine, so it's definitively not an Android issue. Knowing that, I'm glad to inform you that your app' is compatible with the lastest Android version !

Also, adding "api" to extra path don't fix the issue for me right now, but I'll investigate on sickrage instead of bothering you.

Thank you for your time.

dmstocking commented 9 years ago

If you find that there is a easy fix, tell me. I have been pretty awful with updating the app since I got a job, but I will try.

viperidae commented 9 years ago

It appears to be in org.sickbeard Show.java on line 116 SickRage doesn't have a season_folders value on the JSON for the shows command. Doing a null-check on json.search_folders before reading the value would probably fix it. Alternatively.. SickRage could add that value back to the API...