dmstr / yii2-adminlte-asset

AdminLTE Asset Bundle for Backend Theme in Yii2 Framework
1.14k stars 425 forks source link

Badge misalignment in dmstr\widgets\Menu with Firefox #117

Closed maxxer closed 7 years ago

maxxer commented 7 years ago

screenshot-localhost-2017-06-20-22-11-49

This has been fixed upstream, but apparently is still affecting the menus created with Yii2

githubjeka commented 7 years ago

Can you show your render HTML and php code for this item ? What version browser and adminLTE used?

maxxer commented 7 years ago
<ul class="sidebar-menu">
  <li>
    <a href="/TEST-ADMINLTE/web/index.php?r=mailbox">
    <i class="fa fa-fa fa fa-envelope-o"></i>  <span>
      <span>Mailbox</span>
      <span class="pull-right-container">
        <small class="label pull-right bg-yellow">2</small>
      </span>
    </span>
  </a>
  </li>
  <li class="header">
    <span>Menu Yii2</span>
  </li>
  <li><a href="/TEST-ADMINLTE/web/index.php?r=gii">
    <i class="fa fa-file-code-o"></i>  
    <span>Gii</span>
  </a>
  </li>
  <li><a href="/TEST-ADMINLTE/web/index.php?r=debug">
    <i class="fa fa-dashboard"></i>  
    <span>Debug</span>
  </a>
  </li>
  <li>
    <a href="/TEST-ADMINLTE/web/index.php?r=site%2Flogin">
      <i class="fa fa-circle-o"></i>  
      <span>Login</span>
    </a>
  </li>
  <li><a href="#">
    <i class="fa fa-share"></i>  
    <span>Same tools</span> 
    <span class="pull-right-container">
      <i class="fa fa-angle-left pull-right"></i>
    </span>
  </a>
    <ul class='treeview-menu'>
      <li><a href="/TEST-ADMINLTE/web/index.php?r=gii">
        <i class="fa fa-file-code-o"></i>  
        <span>Gii</span>
      </a>
      </li>
      <li><a href="/TEST-ADMINLTE/web/index.php?r=debug">
        <i class="fa fa-dashboard"></i>  
        <span>Debug</span>
      </a>
      </li>
      <li><a href="#">
        <i class="fa fa-circle-o"></i>  
        <span>Level One</span> 
        <span class="pull-right-container">
          <i class="fa fa-angle-left pull-right"></i>
        </span>
      </a>
        <ul class='treeview-menu'>
          <li><a href="#"><i class="fa fa-circle-o"></i>  
            <span>Level Two</span>
          </a>
          </li>
          <li>
            <a href="#">
              <i class="fa fa-circle-o"></i>  
              <span>Level Two</span> 
              <span class="pull-right-container">
                <i class="fa fa-angle-left pull-right"></i>
              </span>
            </a>
            <ul class='treeview-menu'>
              <li><a href="#"><i class="fa fa-circle-o"></i>  <span>Level Three</span></a></li>
              <li><a href="#"><i class="fa fa-circle-o"></i>  <span>Level Three</span></a></li>
            </ul>
          </li>
        </ul>
      </li>
    </ul>
  </li>
</ul>
$ composer.phar show
almasaeed2010/adminlte             v2.3.11 AdminLTE - admin control panel and dashboard that's based on Bootstrap 3

Firefox 54.0.1 (64 bit) on MacOS

githubjeka commented 7 years ago

Catched. Will fixed.

githubjeka commented 7 years ago

Please check your code by latest doc for this case

'items' => [
    [
        'label' => 'Mailbox',
        'icon' => 'envelope-o',
        'url' => ['/mailbox'],
        'template'=>'<a href="{url}">{icon} {label}<span class="pull-right-container"><small class="label pull-right bg-yellow">123</small></span></a>'
    ],
]
githubjeka commented 7 years ago

To enhancement need replace this

'template'=>'<a href="{url}">{icon} {label}<span class="pull-right-container"><small class="label pull-right bg-yellow">123</small></span></a>'

to an attribute of Menu

maxxer commented 7 years ago

great, thanks!