search

dmstr / yii2-adminlte-asset

AdminLTE Asset Bundle for Backend Theme in Yii2 Framework
1.14k stars 426 forks source link

bootstrap 5 support #208

Open sihar opened 1 year ago

sihar commented 1 year ago

Currently yii2 is already using bootstrap 5, do we need to add a new branch to support bootstrap 5?

schmunk42 commented 1 year ago

I don't think we'll find time to update to a major version, see https://github.com/dmstr/yii2-adminlte-asset/issues/183#issuecomment-1629041132

mgrechanik commented 3 months ago

@schmunk42 Is it possible to have both bootstrap5 and this extension?

This composer

        "yiisoft/yii2-bootstrap5": "~2.0.2",
        "yiisoft/yii2-bootstrap4": "~2.0.6",
        "yiisoft/yii2-symfonymailer": "~2.0.3",
        "dmstr/yii2-adminlte-asset": "~2.6.1"

runs to an error

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires yiisoft/yii2-bootstrap5 ~2.0.2 -> satisfiable by yiisoft/yii2-bootstrap5[2.0.2, 2.0.3, 2.0.4].
    - dmstr/yii2-adminlte-asset[2.6.1, ..., 2.6.2] require yiisoft/yii2-bootstrap ~2.0.0 -> satisfiable by yiisoft/yii2-bootstrap[2.0.0, ..., 2.0.11].
    - yiisoft/yii2-bootstrap[2.0.9, ..., 2.0.11] require bower-asset/bootstrap 3.4.* | 3.3.* | 3.2.* | 3.1.* -> satisfiable by bower-asset/bootstrap[v3.1.0, ..., v3.4.1].
    - yiisoft/yii2-bootstrap[2.0.1, ..., 2.0.8] require bower-asset/bootstrap 3.3.* | 3.2.* | 3.1.* -> satisfiable by bower-asset/bootstrap[v3.1.0, ..., v3.3.7].
    - yiisoft/yii2-bootstrap 2.0.0 requires bower-asset/bootstrap 3.2.* | 3.1.* -> satisfiable by bower-asset/bootstrap[v3.1.0, v3.1.1, v3.2.0].
    - You can only install one version of a package, so only one of these can be installed: bower-asset/bootstrap[v3.1.0, ..., v3.4.1, v5.1.0, ..., v5.3.3].
    - yiisoft/yii2-bootstrap5[2.0.2, ..., 2.0.4] require bower-asset/bootstrap ^5.1.0 -> satisfiable by bower-asset/bootstrap[v5.1.0, ..., v5.3.3].
    - Root composer.json requires dmstr/yii2-adminlte-asset ~2.6.1 -> satisfiable by dmstr/yii2-adminlte-asset[2.6.1, 2.6.2].
schmunk42 commented 3 months ago

Is it possible to have both bootstrap5 and this extension?

There's no Bootstrap 5 version of this extension atm. Even Bootstrap 4 in in alpha state.

yii2-boostrap4 and yii2-boostrap5 would install different versions of the bower-asset of bootstrap, this is not possible with composer.

mgrechanik commented 3 months ago

@schmunk42

yii2-boostrap4 and yii2-boostrap5 would install different versions of the bower-asset of bootstrap But when I have only next dependencies, they are installed fine

"yiisoft/yii2-bootstrap5": "~2.0.2",
"yiisoft/yii2-bootstrap4": "~2.0.6",

I cannot use this

"yiisoft/yii2-bootstrap5": "~2.0.2",
"dmstr/yii2-adminlte-asset": "~2.6.1",

With the error

dmstr/yii2-adminlte-asset[2.6.1, ..., 2.6.2] require yiisoft/yii2-bootstrap ~2.0.0

I wonder why it is "require yiisoft/yii2-bootstrap" when it should require yii2-bootstrap4

mgrechanik commented 3 months ago

I understood that stable versions of this extensions are locked with Bootstrap3

    "require": {
        "yiisoft/yii2": "2.*",
        "yiisoft/yii2-bootstrap": "~2.0.0",

So I cannot use Bootstrap5 in my project

schmunk42 commented 3 months ago

As mentioned, there's currently no Bootstrap 5 version of this extension. Only master is on Bootstrap 4.

Feel free to create a PR, we won't have time to update it in the near future.