search

dmstr / yii2-json-editor

Yii2 wrapper for "json-editor/json-editor" (is a fork of "jdorn/json-editor").
BSD 2-Clause "Simplified" License
8 stars 9 forks source link

Widget depends on non-standard application component "Yii::$app->settings" #12

Closed cebe closed 5 years ago

cebe commented 5 years ago

https://github.com/dmstr/yii2-json-editor/blob/24e41099dd4d650d6023f7be945d76e1534565e3/src/JsonEditorWidget.php#L75-L78

  1. this makes it unusable in environments where there is no such component
  2. what does this component do and where to get it?
schmunk42 commented 5 years ago

It's this one: https://github.com/phemellc/yii2-settings

But you're right, this does not belong in this widget @germanbisurgi

Lines 75-79 should be removed.

cebe commented 5 years ago

made a pull request that should keep the functionality but not break other code. If you want to remove it completely I'm fine with that too :)