search

dmsurti / AssimpKit

A library (macOS, iOS) that converts the files supported by Assimp to Scene Kit scenes.
http://assimpkit.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
474 stars 54 forks source link

Imagecache #107

Closed DwayneCoussement closed 5 years ago

DwayneCoussement commented 5 years ago

I had a problem with a certain model where it kept making images and memory went up to 2 GB, on simulator on Mac, on iPhone (even X) it crashed due to memory pressure, this is a quick fix.

DwayneCoussement commented 5 years ago

@dmsurti could you pls have a look? I can still adjust wherever you want.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@c2db445). Click here to learn what that means. The diff coverage is 91.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #107   +/-   ##
=========================================
  Coverage          ?   74.74%           
=========================================
  Files             ?       17           
  Lines             ?     1564           
  Branches          ?        0           
=========================================
  Hits              ?     1169           
  Misses            ?      395           
  Partials          ?        0
Impacted Files Coverage Δ
AssimpKit/Code/Model/SCNTextureInfo.h 100% <ø> (ø)
AssimpKit/Code/Model/AssimpImageCache.m 100% <100%> (ø)
AssimpKit/Code/Model/AssimpImporter.m 89.08% <100%> (ø)
AssimpKit/Code/Model/SCNTextureInfo.m 96.74% <84.21%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c2db445...91c2508. Read the comment docs.

dmsurti commented 5 years ago

@DwayneCoussement Thanks 👍 💯 for the image cache feature. Sorry for the delayed response, super busy at work!