Closed Norod closed 6 years ago
Merging #108 into master will increase coverage by
0.3%
. The diff coverage is94%
.
@@ Coverage Diff @@
## master #108 +/- ##
=========================================
+ Coverage 74.76% 75.06% +0.3%
=========================================
Files 17 17
Lines 1565 1596 +31
=========================================
+ Hits 1170 1198 +28
- Misses 395 398 +3
Impacted Files | Coverage Δ | |
---|---|---|
AssimpKit/Code/Model/Tests/AssimpImporterTests.m | 64.5% <100%> (-0.17%) |
:arrow_down: |
AssimpKit/Code/Model/AssimpImageCache.m | 81.81% <71.42%> (-18.19%) |
:arrow_down: |
AssimpKit/Code/Model/AssimpImporter.m | 89.08% <93.33%> (-0.02%) |
:arrow_down: |
AssimpKit/Code/Model/SCNTextureInfo.m | 97.22% <95.71%> (+0.47%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 45dbbb7...8d6df57. Read the comment docs.
@Norod Thanks for these contributions, extremely useful.
Any chance, you can give a shot to resolve the conflicts? Otherwise I will give it a dash in the weekend post Sep 20.
Sincerely apologize for the delay, work took priority!
Thanks again.
Hello
Your library is awesome. I had a separate branch forked out of yours for a while. Merging in your recent commit (UIImage/NSImage + Cache), I got a lot of conflicts as we both addressed the same image memory issues :) So, I decided to take your most recent branch and apply my code updates to it (to have a small number of commits) and make this PR. I hope you find it (or parts of it) useful.
Change list:
Regards, Doron Adler