search

dmsurti / AssimpKit

A library (macOS, iOS) that converts the files supported by Assimp to Scene Kit scenes.
http://assimpkit.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
477 stars 54 forks source link

Support for vertex colors. #88

Closed tsharju closed 6 years ago

tsharju commented 6 years ago

Adds geometry source with semantic SCNGeometrySourceSemanticColor if a mesh has vertex colors specified.

dmsurti commented 6 years ago

@tsharju Thanks! Merging this.

Could you attach a sample file to test this out? I am not sure if the any of the current model files in the repo demonstrate this feature :-).

tsharju commented 6 years ago

Thanks for merging. I will add a sample file.

dmsurti commented 6 years ago

I will add a sample file.

@tsharju Thanks.

I made a few fixes today for failing test suite; there are 3 files that failed verification after adding support for vertex colors. So if you send me the sample file, we have 4 files to verify the vertex colors! These files are in here.

If you know a quick fix for these files failing, and can fix it; that will be great. Otherwise, no worries, I will fix it when I get around to it. Cheers!

tsharju commented 6 years ago

Sorry, I kinda forgot that the tests with those files failed. I will check why. I have tested with plenty of files, but those are part of our game project and I cannot upload them here.