dmtrKovalenko / cypress-real-events

Fire native system events from Cypress.
MIT License
755 stars 67 forks source link

feat(commands): allow to fallback to `charCodeAt` if key is not in keyCodeDefinitions #631

Open huang-julien opened 6 months ago

huang-julien commented 6 months ago

Hello :wave:

This PR aims to add a fallback to String.charCodeAt if the key is a single character or a unicode char and if it is not in the KeyCodeDefinition.

This would resolve #614.

what-the-diff[bot] commented 6 months ago
dmtrKovalenko commented 6 months ago

I really do not understand why because if you don't type a real keycode it is better to use cy.type simply. Plus I expect at least few tests to be written I am not sure it is even working — you need to pass text separately in the CDP

huang-julien commented 6 months ago

oh cy.type doesn't work with things like CKeditor. But i do get why you quite reluctant to add a change to it 🙂

Some very simple test were added but that's probably not enough ? I'm good with closing it if you feel that this shouldn't be supported

dmtrKovalenko commented 6 months ago

I'm okay but we need to support as much tests as we need like switching between supported keystrokes and not supported, entering utf-8 characters and so on