feat(luxon): Use `DateTime.isDateTime` instead of `instanceof`

dmtrKovalenko / date-io

Abstraction over common javascript date management libraries

MIT License

727 stars 90 forks source link

feat(luxon): Use `DateTime.isDateTime` instead of `instanceof` #639

Closed alex-kuck closed 1 year ago

alex-kuck commented 1 year ago

The usage of DateTime.isDateTime should be more stable without breaking existing behavior. It also satisfies the current version constraints of luxon (added in 1.6.0).

alex-kuck commented 1 year ago

For context: the current implementation using instanceof breaks, when two different versions of luxon are in use (accidentally discovered due to a misconfiguration of our bundler 😅 )