Reduce size of npm package - Githubissues

dmtrKovalenko / odiff

The fastest pixel-by-pixel image visual difference tool in the world.

MIT License

2.04k stars 74 forks source link

Reduce size of npm package #50

Open eWert-Online opened 3 years ago

eWert-Online commented 3 years ago

I recently investigated why the size of the package is that big and found out, that we include a lot of unnecessary stuff. It also seems like esy includes the RunTests.exe in the release build.

Things that can be removed from the package:

[x] ~odiff-Linux-xxx.tar.gz~
[x] ~odiff-MacOS-xxx.tar.gz~
[x] ~odiff-Windows_x64-xxx.tar.gz~
[ ] RunTests.exe

dmtrKovalenko commented 3 years ago

I am not publishing them on npm https://www.jsdelivr.com/package/npm/odiff-bin I left them to publish as assets to GitHub release (I know one team that are using raw binaries to run odiff)

eWert-Online commented 3 years ago

Ah I see! But the RunTests.exe is something which could be removed, right?

dmtrKovalenko commented 3 years ago

Is it there?

eWert-Online commented 3 years ago

Yes, in the bin folder after you install it. So it seems to be packaged by esy

Bildschirmfoto 2021-07-01 um 13 19 58

dmtrKovalenko commented 3 years ago

Hmmm it is weird, I thought "includePackages": [ "odiff" ] should do the trick but yeah we should not add this to the binary