dmtrKovalenko / odiff

The fastest pixel-by-pixel image visual difference tool in the world.
MIT License
2.03k stars 74 forks source link

[bug] Image comparaison issue #72

Closed jsfez closed 1 year ago

jsfez commented 1 year ago

Hello Dmitriy,

Your project seems amazing and I would like to use it but I found an issue in image comparison.

It seems that odiff can't see the differences between this images.

rect

rect-new

dmtrKovalenko commented 1 year ago

Wow that is very unfortunate! Will take a look into this issue today

jsfez commented 1 year ago

Thank a lot

dmtrKovalenko commented 1 year ago

diff

In your case you should pass the -t 0 it looks like the algorithm that we are using treats these 2 colors very similar and the default threshold omits this from the diff

jsfez commented 1 year ago

Thank you for your help and reactivity! For archives, I set the threshold to 0.07.

Otherwise, I've seen that you have worked for Material UI. So you may have used Argos for automatic visual testing. We are working on a complete rework, and if the tests are conclusive, we will use Odiff instead of ImageMagick.