dmulloy2 / ProtocolLib

Provides read and write access to the Minecraft protocol with Bukkit.
GNU General Public License v2.0
1.02k stars 260 forks source link

Error with viaversion #1600

Closed KadTheAad closed 2 years ago

KadTheAad commented 2 years ago

Describe the bug When you join on 1.8.9 bugs start to happen To Reproduce Steps to reproduce the behavior:

  1. Add via* and protocollib to plugins folder
  2. Start server
  3. Join the server
  4. See error

Expected behavior No weird errors happen Logs

[10:14:08 INFO]: DiamondLuda joined the game
[10:14:08 INFO]: DiamondLuda[/127.0.0.1:60753] logged in with entity id 78 at ([world]-18.5, 68.0, -5.5)
[10:14:08 INFO]: DiamondLuda lost connection: Internal Exception: io.netty.handler.codec.CorruptedFrameException: length wider than 21-bit
[10:14:08 INFO]: DiamondLuda left the game
[10:14:10 INFO]: UUID of player DiamondLuda is 6ab49aec-d093-4eec-8812-89f95f6b0bf5
[10:14:10 INFO]: DiamondLuda joined the game
[10:14:10 INFO]: DiamondLuda[/127.0.0.1:60759] logged in with entity id 79 at ([world]-18.5, 68.0, -5.5)
[10:14:10 INFO]: DiamondLuda lost connection: Internal Exception: io.netty.handler.codec.CorruptedFrameException: length wider than 21-bit
[10:14:10 INFO]: DiamondLuda left the game
[10:14:14 INFO]: UUID of player DiamondLuda is 6ab49aec-d093-4eec-8812-89f95f6b0bf5
[10:14:14 INFO]: DiamondLuda joined the game
[10:14:14 INFO]: DiamondLuda[/127.0.0.1:60765] logged in with entity id 80 at ([world]-18.5, 68.0, -5.5)
[10:14:27 INFO]: DiamondLuda lost connection: Internal Exception: io.netty.handler.codec.DecoderException: Badly compressed packet - size of 1537390758 is larger than protocol maximum of 8388608
[10:14:27 INFO]: DiamondLuda left the game
[10:14:30 INFO]: UUID of player DiamondLuda is 6ab49aec-d093-4eec-8812-89f95f6b0bf5
[10:14:30 INFO]: DiamondLuda joined the game
[10:14:30 INFO]: DiamondLuda[/127.0.0.1:60782] logged in with entity id 81 at ([world]-18.5, 68.0, -5.5)
[10:14:30 INFO]: DiamondLuda lost connection: Internal Exception: io.netty.handler.codec.DecoderException: java.util.zip.DataFormatException: incorrect header check
[10:14:30 INFO]: DiamondLuda left the game
[10:14:32 INFO]: UUID of player DiamondLuda is 6ab49aec-d093-4eec-8812-89f95f6b0bf5
[10:14:32 INFO]: DiamondLuda joined the game
[10:14:32 INFO]: DiamondLuda[/127.0.0.1:60785] logged in with entity id 82 at ([world]-18.5, 68.0, -5.5)
[10:14:33 INFO]: DiamondLuda lost connection: Internal Exception: io.netty.handler.codec.DecoderException: Badly compressed packet - size of 109 is below server threshold of 256
[10:14:33 INFO]: DiamondLuda left the game
[10:14:35 INFO]: UUID of player DiamondLuda is 6ab49aec-d093-4eec-8812-89f95f6b0bf5
[10:14:35 INFO]: DiamondLuda joined the game
[10:14:35 INFO]: DiamondLuda[/127.0.0.1:60787] logged in with entity id 83 at ([world]-18.5, 68.0, -5.5)
[10:14:36 INFO]: DiamondLuda lost connection: Internal Exception: io.netty.handler.codec.DecoderException: java.util.zip.DataFormatException: incorrect header check
[10:14:36 INFO]: DiamondLuda left the game
[10:14:39 INFO]: UUID of player DiamondLuda is 6ab49aec-d093-4eec-8812-89f95f6b0bf5
[10:14:39 INFO]: DiamondLuda joined the game
[10:14:39 INFO]: DiamondLuda[/127.0.0.1:60793] logged in with entity id 84 at ([world]-18.5, 68.0, -5.5)
[10:14:39 INFO]: DiamondLuda lost connection: Internal Exception: io.netty.handler.codec.DecoderException: Badly compressed packet - size of 109 is below server threshold of 256
[10:14:39 INFO]: DiamondLuda left the game
[10:14:41 INFO]: UUID of player DiamondLuda is 6ab49aec-d093-4eec-8812-89f95f6b0bf5
[10:14:42 INFO]: DiamondLuda joined the game
[10:14:42 INFO]: DiamondLuda[/127.0.0.1:60801] logged in with entity id 85 at ([world]-18.5, 68.0, -5.5)
[10:14:42 INFO]: DiamondLuda lost connection: Internal Exception: io.netty.handler.codec.DecoderException: java.lang.RuntimeException: VarInt too big
[10:14:42 INFO]: DiamondLuda left the game
[10:14:43 INFO]: com.mojang.authlib.GameProfile@7f03481a[id=<null>,name=DiamondLuda,properties={},legacy=false] (/127.0.0.1:60803) lost connection: Disconnected
[10:14:44 INFO]: com.mojang.authlib.GameProfile@6b48ea00[id=<null>,name=DiamondLuda,properties={},legacy=false] (/127.0.0.1:60804) lost connection: Disconnected
[10:14:46 INFO]: com.mojang.authlib.GameProfile@6ebabb82[id=<null>,name=DiamondLuda,properties={},legacy=false] (/127.0.0.1:60805) lost connection: Disconnected
[10:14:49 INFO]: com.mojang.authlib.GameProfile@7f4a153a[id=<null>,name=DiamondLuda,properties={},legacy=false] (/127.0.0.1:60814) lost connection: Disconnected
[10:15:04 INFO]: UUID of player DiamondLuda is 6ab49aec-d093-4eec-8812-89f95f6b0bf5
[10:15:04 INFO]: DiamondLuda joined the game
[10:15:04 INFO]: DiamondLuda[/127.0.0.1:60838] logged in with entity id 86 at ([world]-18.5, 68.0, -5.5)
[10:15:05 INFO]: DiamondLuda lost connection: Internal Exception: io.netty.handler.codec.DecoderException: java.util.zip.DataFormatException: incorrect header check
[10:15:05 INFO]: DiamondLuda left the game

Version Info

ProtocolLib Dump
Timestamp: 05/25/22 13:35:19

ProtocolLib Version: ProtocolLib v5.0.0-SNAPSHOT-b554
Bukkit Version: 1.18.2-R0.1-SNAPSHOT
Server Version: git-Paper-344 (MC: 1.18.2)
Java Version: 17.0.2

ProtocolLib: com.comphenix.protocol.ProtocolLib@7b464a2f[
  statistics=com.comphenix.protocol.metrics.Statistics@273520fe
  backgroundCompiler=com.comphenix.protocol.reflect.compiler.BackgroundCompiler@282febfc
  packetTask=7
  tickCounter=898
  configExpectedMod=1
  updater=com.comphenix.protocol.updater.SpigotUpdater@722dedb8
  redirectHandler=com.comphenix.protocol.ProtocolLib$2@3b73d6e0
  commandProtocol=com.comphenix.protocol.CommandProtocol@35cf23a0
  commandPacket=com.comphenix.protocol.CommandPacket@62e85eee
  commandFilter=com.comphenix.protocol.CommandFilter@7f353f26
  packetLogging=com.comphenix.protocol.PacketLogging@5ad432f6
  skipDisable=false
  isEnabled=true
  loader=org.bukkit.plugin.java.JavaPluginLoader@164ad82f
  server=CraftServer{serverName=Paper,serverVersion=git-Paper-344,minecraftVersion=1.18.2}
  file=plugins/ProtocolLib.jar
  description=org.bukkit.plugin.PluginDescriptionFile@60ef2ec1
  dataFolder=plugins/ProtocolLib
  classLoader=PluginClassLoader{plugin=ProtocolLib v5.0.0-SNAPSHOT-b554, pluginEnabled=true, url=plugins/ProtocolLib.jar}
  naggable=true
  newConfig=YamlConfiguration[path='', root='YamlConfiguration']
  configFile=plugins/ProtocolLib/config.yml
  logger=com.destroystokyo.paper.utils.PaperPluginLogger@5b9ccb5d
]
Manager: com.comphenix.protocol.injector.PacketFilterManager@4229a7c3[
  plugin=ProtocolLib v5.0.0-SNAPSHOT-b554
  server=CraftServer{serverName=Paper,serverVersion=git-Paper-344,minecraftVersion=1.18.2}
  reporter=com.comphenix.protocol.ProtocolLib$1@5b291061
  minecraftVersion=(MC: 1.18.2)
  asyncFilterManager=com.comphenix.protocol.async.AsyncFilterManager@7f47f21f
  pluginVerifier=com.comphenix.protocol.injector.PluginVerifier@423c0889
  inboundListeners=com.comphenix.protocol.injector.SortedPacketListenerList@4d24a8b2
  outboundListeners=com.comphenix.protocol.injector.SortedPacketListenerList@5e1d136f
  registeredListeners=[PacketAdapter[plugin=Themis, sending=ListeningWhitelist[priority=NORMAL, packets=[EXPLOSION[class=PacketPlayOutExplosion, id=28]], gamephase=PLAYING, options=[]], receiving=EMPTY_WHITELIST], PacketAdapter[plugin=SuperVanish, sending=ListeningWhitelist[priority=LOW, packets=[PLAYER_INFO[class=PacketPlayOutPlayerInfo, id=54], ENTITY_METADATA[class=PacketPlayOutEntityMetadata, id=77], ABILITIES[class=PacketPlayOutAbilities, id=50]], gamephase=PLAYING, options=[]], receiving=EMPTY_WHITELIST], PacketAdapter[plugin=Themis, sending=EMPTY_WHITELIST, receiving=ListeningWhitelist[priority=NORMAL, packets=[POSITION[class=PacketPlayInPosition, id=17], GROUND[class=d, id=20], POSITION_LOOK[class=PacketPlayInPositionLook, id=18], LOOK[class=PacketPlayInLook, id=19]], gamephase=PLAYING, options=[]]], PacketAdapter[plugin=Themis, sending=EMPTY_WHITELIST, receiving=ListeningWhitelist[priority=NORMAL, packets=[PONG[class=ServerboundPongPacket, id=29]], gamephase=PLAYING, options=[]]], PacketAdapter[plugin=Themis, sending=EMPTY_WHITELIST, receiving=ListeningWhitelist[priority=NORMAL, packets=[ABILITIES[class=PacketPlayInAbilities, id=25]], gamephase=PLAYING, options=[]]], PacketAdapter[plugin=SuperVanish, sending=ListeningWhitelist[priority=NORMAL, packets=[PLAYER_INFO[class=PacketPlayOutPlayerInfo, id=54]], gamephase=PLAYING, options=[]], receiving=EMPTY_WHITELIST], PacketAdapter[plugin=Themis, sending=EMPTY_WHITELIST, receiving=ListeningWhitelist[priority=LOW, packets=[POSITION[class=PacketPlayInPosition, id=17], GROUND[class=d, id=20], POSITION_LOOK[class=PacketPlayInPositionLook, id=18], LOOK[class=PacketPlayInLook, id=19]], gamephase=PLAYING, options=[]]], PacketAdapter[plugin=SuperVanish, sending=ListeningWhitelist[priority=HIGH, packets=[PLAYER_INFO[class=PacketPlayOutPlayerInfo, id=54]], gamephase=PLAYING, options=[]], receiving=EMPTY_WHITELIST], PacketAdapter[plugin=SuperVanish, sending=ListeningWhitelist[priority=NORMAL, packets=[OUT_SERVER_INFO[class=PacketStatusOutServerInfo, id=0]], gamephase=PLAYING, options=[]], receiving=EMPTY_WHITELIST], PacketAdapter[plugin=Themis, sending=ListeningWhitelist[priority=NORMAL, packets=[KEEP_ALIVE[class=PacketPlayInKeepAlive, id=15], KEEP_ALIVE[class=PacketPlayOutKeepAlive, id=33]], gamephase=PLAYING, options=[]], receiving=ListeningWhitelist[priority=NORMAL, packets=[KEEP_ALIVE[class=PacketPlayInKeepAlive, id=15], KEEP_ALIVE[class=PacketPlayOutKeepAlive, id=33]], gamephase=PLAYING, options=[]]]]
  packetInjector=com.comphenix.protocol.injector.netty.manager.NetworkManagerPacketInjector@1e0ad5b9
  playerInjectionHandler=com.comphenix.protocol.injector.netty.manager.NetworkManagerPlayerInjector@3cd0eeb1
  networkManagerInjector=com.comphenix.protocol.injector.netty.manager.NetworkManagerInjector@54d9a0a1
  debug=false
  closed=false
  injected=true
]

Listeners:
com.gmail.olexorus.themis.Wm@7bb179f1[
  s=com.gmail.olexorus.themis.Z@6269573e
  plugin=Themis v0.12.2
  connectionSide=SERVER_SIDE
  receivingWhitelist=EMPTY_WHITELIST
  sendingWhitelist=ListeningWhitelist[priority=NORMAL, packets=[EXPLOSION[class=PacketPlayOutExplosion, id=28]], gamephase=PLAYING, options=[]]
]
de.myzelyam.supervanish.features.SilentOpenChestPacketAdapter@13f6e427[
  silentOpenChest=de.myzelyam.supervanish.features.SilentOpenChest@760658ed
  suppressErrors=false
  plugin=SuperVanish v6.2.7
  connectionSide=SERVER_SIDE
  receivingWhitelist=EMPTY_WHITELIST
  sendingWhitelist=ListeningWhitelist[priority=LOW, packets=[PLAYER_INFO[class=PacketPlayOutPlayerInfo, id=54], ENTITY_METADATA[class=PacketPlayOutEntityMetadata, id=77], ABILITIES[class=PacketPlayOutAbilities, id=50]], gamephase=PLAYING, options=[]]
]
com.gmail.olexorus.themis.WU@91efa2d[
  q=com.gmail.olexorus.themis.Z@6269573e
  plugin=Themis v0.12.2
  connectionSide=CLIENT_SIDE
  receivingWhitelist=ListeningWhitelist[priority=NORMAL, packets=[POSITION[class=PacketPlayInPosition, id=17], GROUND[class=d, id=20], POSITION_LOOK[class=PacketPlayInPositionLook, id=18], LOOK[class=PacketPlayInLook, id=19]], gamephase=PLAYING, options=[]]
  sendingWhitelist=EMPTY_WHITELIST
]
com.gmail.olexorus.themis.mW@5ea94eed[
  plugin=Themis v0.12.2
  connectionSide=CLIENT_SIDE
  receivingWhitelist=ListeningWhitelist[priority=NORMAL, packets=[PONG[class=ServerboundPongPacket, id=29]], gamephase=PLAYING, options=[]]
  sendingWhitelist=EMPTY_WHITELIST
]
com.gmail.olexorus.themis.BW@e31815[
  a=com.gmail.olexorus.themis.Z@6269573e
  plugin=Themis v0.12.2
  connectionSide=CLIENT_SIDE
  receivingWhitelist=ListeningWhitelist[priority=NORMAL, packets=[ABILITIES[class=PacketPlayInAbilities, id=25]], gamephase=PLAYING, options=[]]
  sendingWhitelist=EMPTY_WHITELIST
]
de.myzelyam.supervanish.features.VanishIndication$1@13590b2e[
  plugin=SuperVanish v6.2.7
  connectionSide=SERVER_SIDE
  receivingWhitelist=EMPTY_WHITELIST
  sendingWhitelist=ListeningWhitelist[priority=NORMAL, packets=[PLAYER_INFO[class=PacketPlayOutPlayerInfo, id=54]], gamephase=PLAYING, options=[]]
]
com.gmail.olexorus.themis.eS@6cf56dfc[
  plugin=Themis v0.12.2
  connectionSide=CLIENT_SIDE
  receivingWhitelist=ListeningWhitelist[priority=LOW, packets=[POSITION[class=PacketPlayInPosition, id=17], GROUND[class=d, id=20], POSITION_LOOK[class=PacketPlayInPositionLook, id=18], LOOK[class=PacketPlayInLook, id=19]], gamephase=PLAYING, options=[]]
  sendingWhitelist=EMPTY_WHITELIST
]
de.myzelyam.supervanish.visibility.hiders.modules.PlayerInfoModule@1cb96960[
  hider=de.myzelyam.supervanish.visibility.hiders.PreventionHider@6d42f023
  plugin=SuperVanish v6.2.7
  errorLogged=false
  plugin=SuperVanish v6.2.7
  connectionSide=SERVER_SIDE
  receivingWhitelist=EMPTY_WHITELIST
  sendingWhitelist=ListeningWhitelist[priority=HIGH, packets=[PLAYER_INFO[class=PacketPlayOutPlayerInfo, id=54]], gamephase=PLAYING, options=[]]
]
de.myzelyam.supervanish.visibility.ServerListPacketListener@1717e02b[
  plugin=SuperVanish v6.2.7
  plugin=SuperVanish v6.2.7
  connectionSide=SERVER_SIDE
  receivingWhitelist=EMPTY_WHITELIST
  sendingWhitelist=ListeningWhitelist[priority=NORMAL, packets=[OUT_SERVER_INFO[class=PacketStatusOutServerInfo, id=0]], gamephase=PLAYING, options=[]]
]
com.gmail.olexorus.themis.B7@349ca9e2[
  plugin=Themis v0.12.2
  connectionSide=BOTH
  receivingWhitelist=ListeningWhitelist[priority=NORMAL, packets=[KEEP_ALIVE[class=PacketPlayInKeepAlive, id=15], KEEP_ALIVE[class=PacketPlayOutKeepAlive, id=33]], gamephase=PLAYING, options=[]]
  sendingWhitelist=ListeningWhitelist[priority=NORMAL, packets=[KEEP_ALIVE[class=PacketPlayInKeepAlive, id=15], KEEP_ALIVE[class=PacketPlayOutKeepAlive, id=33]], gamephase=PLAYING, options=[]]
]

Plugins Using ProtocolLib:
Themis by [Olexorus]
SuperVanish by [MyzelYam]
derklaro commented 2 years ago

That issue is fixed in the latest development build of ViaVersion, please download it from here